Refactor xgboost dependencies for platform compatibility#156
Merged
Conversation
Updated xgboost-cpu and xgboost version specifications for better compatibility across platforms.
Member
|
Although this PR fixes the issue it is due to a "patch by accident" if I read your intent correctly. The switches were correct and platform compatibility was discerned correctly. The versions got out of sync in an update it seemed. I patches this here to always install 3.3.0: ceb88f5 Still in favor for merging this, as it mitigates this problem from happening again. Feel free to merge after view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently it fails with:
as on Darwin both settings hold